Repository navigation
Add support for breakglass for immutable folders - #6774
Merged
Merged
Conversation
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: f5c8dc1
Top 6 slowest tests (at least 2 minutes):
|
pietern
reviewed
Sep 25, 2026
| return 0, nil | ||
| } | ||
|
|
||
| entry, ok := b.DeploymentBundle.StateDB.GetResourceEntry(resources.SnapshotKey) |
Contributor
There was a problem hiding this comment.
This reads state and makes a determination. Shouldn't that live in a DoRead of the snapshot?
I.e. seeing a different generation, or a "broken_glass: true" on DoRead can trigger recreation.
Contributor
Author
There was a problem hiding this comment.
There are a couple of blockers why it is not in DoRead, mainly the --force flag, which is not available at the resource level
It's also conceptually similar to existing CheckDashboardsModifiedRemotely check we have
| // ContentSubdir is the fixed subfolder the snapshot API appends to a caller-supplied | ||
| // relative_path to form the immutable content path (e.g. "<root>/<relative_path>/snapshot"). | ||
| // The content path is what the create API echoes back and what InspectSnapshot inspects. | ||
| const ContentSubdir = "snapshot" |
Contributor
Author
There was a problem hiding this comment.
I think it's related to the fact that when we upload zip, we create 2 folders: one snapshot which can be broken glass and one is .internal which is not and contains a break glass marker and some other metadata
pietern
reviewed
Sep 25, 2026
Contributor
|
Commit: Regression test reportSelected 13 changed tests (limit=20, 0 not selected) 17 tests: regression=17 unreleased=0 coverage=0 failing=0
TestAccept/bundle/deploy/immutable/basic/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): TestAccept/bundle/deploy/immutable/breakglass/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): TestAccept/bundle/deploy/immutable/can-manage/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): TestAccept/bundle/deploy/immutable/destroy-redeploy/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): same output as main (accb3df) TestAccept/bundle/deploy/immutable/dev-mode/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): same output as main (accb3df) TestAccept/bundle/deploy/immutable/legacy-state/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): same output as main (accb3df) TestAccept/bundle/deploy/immutable/missing-snapshot/DMS=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): same output as main (accb3df) TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN=: branch ✅ | main (accb3df) ❌ | latest (v1.22.1) ❌main (accb3df): latest (v1.22.1): same output as main (accb3df) 9 more failure details omitted, see the full report in the run. |
Contributor
Why don't we make it normal behavior, without --force? |
Contributor
Author
|
@denik we don't want users accidentally overwrite any fixes made in breakglass version, hence it's an explicit --force action needed |
janniklasrose
approved these changes
Oct 27, 2026
andrewnester
enabled auto-merge
October 27, 2026 11:34
Collaborator
Integration test reportCommit: 8191901
12 interesting tests: 8 flaky, 4 FAIL
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Oct 29, 2026
## Release v1.23.0 ### CLI * Fix GitHub API rate limit errors in `aitools list` and plugin installs by pinning skills to `0.2.32`. ([#7159](#7159)) * `databricks ssh connect` now makes `claude` and `codex` available on dedicated clusters. ([#7190](#7190)) * `databricks ssh connect` on serverless now makes `claude` and `codex` available in IDE sessions (`--ide`) and to non-interactive commands (e.g. `databricks ssh connect -- 'claude -p "..."'`). ([#7123](#7123)) ### AI Runtime * Add workload support for the GPU_1xRTX6000 accelerator type in enabled workspaces. ([#7214](#7214)) * Show only the accelerator types available in the current workspace in `databricks air run -h config.compute`. ([#6993](#6993)) ### Bundles * Fixed `bundle validate` failing with "expected a map to index" when a job `schedule`, `trigger` or `continuous` is a reference to a whole block, such as `${resources.jobs.base.schedule}`. ([#7225](#7225)) * Added `lifecycle.depends_on` to order resources without referencing their fields. ([#7120](#7120)) * Immutable-folder deploys now refuse to deploy onto a snapshot that was modified outside the bundle (break glass); `bundle deploy --force` moves the deployment to a fresh snapshot. ([#6774](#6774)) * Fix `--include-locations` failing when a resource is missing a required field. ([#7185](#7185)) * Removed spurious "required field is not set" warnings for a field whose value is a reference to a whole block, such as `schedule: ${resources.jobs.base.schedule}`. ([#7226](#7226)) * Revert bundle file uploads to the legacy `/workspace-files/import-file` endpoint, rolling back [#6149](#6149) and [#7034](#7034) released in [v1.21.0](https://github.com/databricks/cli/releases/tag/v1.21.0). This fixes notebooks being uploaded as plain files and deployments failing (for example SQL notebooks in [#7216](#7216)). A remote file or notebook whose type differs from the local one is now deleted and replaced instead of blocking the deploy. ([#7218](#7218)) * Support selecting resources for deletion with `bundle deploy --select`. ([#7023](#7023)) * Add the `workspace.sync_mode` setting with the values `overwrite` (default), `in-place`, and `immutable`. It replaces `presets.source_linked_deployment` (use `in-place`) and `experimental.immutable_folder` (use `immutable`), which are now deprecated and emit a warning. ([#7183](#7183)) ### Dependency Updates * Bump dependencies with known vulnerabilities. ([#7213](#7213)) * Update the Go SDK to [v0.190.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.190.0). ([#7155](#7155)) * Update the Go SDK to [v0.191.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.191.0). ([#7211](#7211)) * Bump Node.js downloaded by the `ssh` agent shim from v24.21.0 to v24.22.2. ([#7246](#7246))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add support for breakglass for immutable folders
Why
Immutable folders can be "break-glassed" in an emergency. In this case, CLI should prevent a normal deploy if the previously used snapshot was broken. With --force, it should allow to deploy to a new suffixed path and the deployments after should continue as normal
Tests
Added an acceptance test